Skip to content

feature(accordion): Added accordion components to the project

Tadeusz Miesiąc requested to merge feature/MIN-74-accordion-component into development

Description

Added accordion components to the project. Decided to use library because of bigger flexibility and time-save. I had two options

  • Custom component Pros: Small bundle size, highly customizable Cons: Time consuming: would have to implement reusable and composable component + analise all cases that occurs in the app. There is danger that all cases are not included in designs so it would require to spend even more time
  • Library Pros:
  • huge time save, customizable Cons: 100kb unpacked size, 10kb gziped -> It would highly increase bundle size. But it's ok for me cuz it's CSR where it doesn't matter that much comparing to SSR or Static website

Implementation reasoning

Imported each of library module and exported it as custom component to add custom styling to it.

Additionally

  • Moved global styles import to pages wrapper (_app.tsx)
  • Removed redux-page example - its no longer needed
  • Created usage example http://localhost:3000/accordion-test

Merge request reports